BIND 10 #2650: Errors from cppcheck 1.58

[BIND 10 Development]

#2650: Errors from cppcheck 1.58
-------------------------------------+-------------------------------------
            Reporter:  vorner        |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130219
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => UnAssigned
 * status:  assigned => reviewing


Comment:

 Up for review. Doesn't require a `ChangeLog`.

 The following are not fixed as they are cppcheck false positives. But I
 want the reviewer to verify these:
 {{{
 src/lib/datasrc/memory/zone_finder.cc:552: check_fail: The class
 'InMemoryZoneFinder' does not have a constructor. (style,noConstructor)
 src/lib/datasrc/memory_datasrc.cc:784: check_fail: The class
 'InMemoryZoneFinder' does not have a constructor. (style,noConstructor)
 src/lib/datasrc/sqlite3_accessor.cc:684: check_fail: The class
 'SQLite3Accessor' does not have a constructor. (style,noConstructor)
 src/lib/datasrc/sqlite3_accessor.cc:889: check_fail: The class
 'SQLite3Accessor' does not have a constructor. (style,noConstructor)
 src/lib/dns/master_loader.cc:57: check_fail: The class 'MasterLoader' does
 not have a constructor. (style,noConstructor)
 }}}

 In each of these cases, the class is prefixed by its enclosing class:
 {{{
 class InMemoryZoneFinder::Context : public ZoneFinder::Context {
 class InMemoryZoneFinder::Context : public ZoneFinder::Context {
 class MasterLoader::MasterLoaderImpl {
 }}}

 cppcheck thinks there's a constructor missing for the enclosing class.
 Constructors are present for the current class (and the enclosing class
 too, but that's not at the failure line).

 I suggest we ignore these until cppcheck gets fixed (and not suppress
 them).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2650#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development