BIND 10 #2679: use value-param tests for database tests, not type-param tests

[BIND 10 Development]

#2679: use value-param tests for database tests, not type-param tests
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  accepted
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130219
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 trac2679 is ready for review.

 I know the diff is big and looks scary, but this is basically
 straightforward refactoring (trust me:-).

 This is suggested guide for the review:

 - the first 2 commits (up to b68752a) are initial preparation, mainly
   consisting of trivial keyword substitution from TYPED_TEST to TEST_P
   or removing `this` (which is not requested in parameterized tests).
   Since the diff so far is big but it's quite trivial, I suggest
   reviewing this part first, separately.
 - next 5 commits (`905792e^..f866170`) complete the conversion.  The
   important changes are the first and last commits.  These include
   some non trivial tricks to adjust the test fixture with the
   parameter framework instead of the template.  The intermediate 3
   (905792e..b20cc15) should be trivial editorial cleanup.  My
   suggestion is to review these 5 commits as a set, concentrating on
   the diff for the first and last commits.

 If the branch looks too big at this point, we can stop and defer the
 rest to another ticket.  In case the rest of the branch is deemed to
 be acceptable: the remaining part is to reorganize the test fixture so
 it will be more easily shared with other accessor implementations.
 Specifically, test fixtures classes were extracted into a separate
 header file (newly created), and the `SQLite3` tests were now moved to
 another separate file (as an example of how to do it for other
 accessors).

 - the first commit in this part (b2ac76a) is big, but it only moves
   the class definitions to the separate header file, and rearranged
   the rest of the code so it compiles successfully.  So, in essence,
   this should be a straightforward update.  I suggest reviewing this
   diff separately.
 - the next 3 commits (b2ac76a..4f5d524) are to move SQLite3 related
   part into a separate file.  This should also be straightforward.
 - The rest (4694c98 and beyond) is documentation and other cleanups.

 This change shouldn't need a changelog entry; it's just an internal
 refactoring for tests.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2679#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development