BIND 10 #2665: fix clang static analyzer issues

[BIND 10 Development]

#2665: fix clang static analyzer issues
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130219
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Hmm, my build-scan defaults to gcc for compilation and linking, while
 CLANGPP is set (so make will fail on -Qunused-arguments), so note to
 people trying to reproduce: use --use-cc and --use-c++ :)

 I wonder if we should make a wiki page with some tips on how to run scan-
 build, as it is relatively easy but not quite trivial :)

 BTW, apart from the paramregistry and rrttl false positives, mine also
 complains about CMSG_FIRSTHDR(&msghdr) returning null (and hence a
 subsequence null dereference), which also seems an invalid complaint.

 As they are, the changes look fine and can be merged.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2665#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development