BIND 10 #2699: DHCP performance: use composite search indexes on the lease4 table to improve performance

[BIND 10 Development]

#2699: DHCP performance: use composite search indexes on the lease4 table to
improve performance
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:  tmark
                Type:  defect        |                       Status:
            Priority:  high          |  reviewing
           Component:  dhcp4         |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130214
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:
         Total Hours:  0             |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => tmark


Comment:

 I made a couple of changes to the !ChangeLog entry and I tell you why:
 - added b10-dhcpX prefix to indicate that the !ChangeLog entry refers to
 the DHCP modules. Note that the most of the BIND10 code is a DNS or common
 modules so it is good to indicate that the change is exclusively for DHCP.
 - It is not true that the lease4 table has two indexes and lease6 table
 has one index. This is simply because they had already got primary keys
 before your change. So in fact they have 3 indexes and 2 indexes
 respectively. I used a word !''additional!'' to point out that some
 indexes had been there.
 - I replaced the !''lease request performance!'' with !''lease acquisition
 performance!'' because the former sounds like the performance of the
 client got improved (so as it can send more requests to the server ) while
 in fact we can acquire leases faster and the client's performance remains
 the same.
 - I added !''tmark!'' as the author of the change so as people can blame
 you if BIND10 breaks on master after your merge :-). If you say !''team!''
 is an author how do people know who is to be blamed? The answer is:
 through the commit log. But still, you have done the change so you should
 be put as an author.

 I also reformatted the entry to something that can be copy-pasted to the
 !ChangeLog file (tabs, spaces etc).

 {{{
 5xx.    [func]          tmark
         b10-dhcp4, b10-dhcp6: Composite key indexes were added to the
 lease
         tables to reduce lease search time. The lease4 table now has two
         additional indexes: a) hwaddr/subnet_id and b)
 client_id/subnet_id.
         The lease6 now has the one additional index: iaid/subnet_id/duid.
         Adding these indexes significantly improves lease acquisition
         performance.
         (Trac #2699,#2703, git
 54bbed5fcbe237c5a49b515ae4c55148723406ce)}}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2699#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development