BIND 10 #2679: use value-param tests for database tests, not type-param tests

[BIND 10 Development]

#2679: use value-param tests for database tests, not type-param tests
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130219
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:8 jinmei]:
 > Thanks for reviewing the big diff!

 Most of it was just very simple replacement, nothing to think about. So it
 just took slightly longer time.

 > {{{#!cpp
 > TEST_RECORDS[][0] = "www.example.org." // and so on
 > TEST_NSEC3_RECORDS[][0] = "0P9MHAVEQVM6T7VBL5LOP2U3T2RP3TOM" // and so
 on
 > }}}
 >
 > ...but, I don't understand the rest of the comment.  What's the load
 > function?

 The `enableNSEC3Generic` function. I mean this code:
 {{{#!c++
     // Add NSEC3s
     for (int i = 0; TEST_NSEC3_RECORDS[i][0] != NULL; ++i) {
         const string
 nsec3_columns[DatabaseAccessor::ADD_NSEC3_COLUMN_COUNT] =
             {
                 Name(TEST_NSEC3_RECORDS[i][0]).split(0, 1).toText(true),
                 TEST_NSEC3_RECORDS[i][2], // TTL
                 TEST_NSEC3_RECORDS[i][1], // RR type
                 TEST_NSEC3_RECORDS[i][4]  // RDATA
             };
         accessor.addNSEC3RecordToZone(nsec3_columns);
     }
 }}}

 Specially, the line:
 {{{#!c++
                 Name(TEST_NSEC3_RECORDS[i][0]).split(0, 1).toText(true),
 }}}

 It seems to expect the string is actually a full name, not just the first
 label (or I don't understand the purpose of the split there).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2679#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development