BIND 10 #2669: Valgrind issues

[BIND 10 Development]

#2669: Valgrind issues
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:
                Type:  task          |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130219
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 I got rid of most of the fork()-related issues by adding --child-silent-
 after-fork=yes (technically this could result in missed issues in forking
 unit tests, but currently it is reporting leaks from stack allocations...)

 I ran it on the centos machine, and there were two issues left in my
 checkout:

 - one was an uninitialized memory block, fixed in the second commit

 - the other one appears to be inside the specific version of libsqlite on
 that old centos. I think I reported this as well last time, and more
 recent versions don't seem to have this issue. Anyway if we're not gonna
 upgrade, this is the repression I used on the centos buildbot:
 {{{
 {
    Old libsqlite3 alloc failure
    Memcheck:Param
    write(buf)
    fun:__write_nocancel
    obj:/usr/lib64/libsqlite3.so.0.8.6
    obj:/usr/lib64/libsqlite3.so.0.8.6
    obj:/usr/lib64/libsqlite3.so.0.8.6
    obj:/usr/lib64/libsqlite3.so.0.8.6
    obj:/usr/lib64/libsqlite3.so.0.8.6
    obj:/usr/lib64/libsqlite3.so.0.8.6
    fun:sqlite3_step
    fun:_ZN3isc7datasrc18StatementProcessor4execEv
    fun:_ZN3isc7datasrc15SQLite3Accessor6commitEv
    fun:_ZN12_GLOBAL__N_128SQLite3Update_addRecord_Test8TestBodyEv
 fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc
 }
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2669#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development