BIND 10 #2669: Valgrind issues

[BIND 10 Development]

#2669: Valgrind issues
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130219
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:9 jelte]:

 >
 > So latest push has more runningOnValgrind() checks (and a few include
 order fixes), and if we don't like that the alternative I can see is to
 rename those tests to something like <test_name>_SKIP_FOR_VALGRIND, and
 set that up as a buildbot filter.

 I'm okay with this approach.  You could have use `runningOnValgrind()`
 like
 {{{#!cpp
     if (runningOnValgrind()) {
         return;
     }
 }}}
 without touching the rest of the code to reduce the amount of diff
 (and keep it shorter in terms of consumed columns), but at this point
 it probably does not make much sense to make that change.  I'd leave
 it to you.

 One last comment: I suggest adding to check_valgrind.h comments (doc)
 that we generally need to use this function and skip test code that
 uses fork() or threads.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2669#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development