BIND 10 #2713: b10-cmdctl-usermgr's prompts should be revisited
BIND 10 Development
do-not-reply at isc.org
Thu Feb 21 15:37:58 UTC 2013
#2713: b10-cmdctl-usermgr's prompts should be revisited
-------------------------------------+-------------------------------------
Reporter: muks | Owner:
Type: defect | UnAssigned
Priority: medium | Status:
Component: cmd-ctl | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130305
Sub-Project: DNS | Resolution:
Estimated Difficulty: 4 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => UnAssigned
* status: assigned => reviewing
Comment:
It's ready for review.
I don't think I left much of the original code intact, so it might be
better to review the code as if it was new.
I added unit tests (there were none), however, they are really more
'system-level', as in they don't care about the actual internal methods
(and don't call any of them directly), just the behaviour of the tool, and
therefore only call it as an external program (with one exception). For
such a simple tool (and methods that aren't called from other sources) I
think that makes more sense.
I did change the command-line arguments from the proposal, instead of a
number of options I added three arguments, two of which are optional
(username and password).
While I was rewriting it anyway it was just as easy to add in a few more
options (some of these are other tickets):
- you can now delete users as well as add them
- there is a -q option that suppresses output (except when it prompts for
data)
- it defaults to sysconfdir/package/cmdctl-accounts.csv instead of `cwd`
It also has better error checking and more graceful error handling than
the original.
--
Ticket URL: <http://bind10.isc.org/ticket/2713#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list