BIND 10 #2386: support generic version of rdata::createRdata(text) in NSEC, DS RDATA

BIND 10 Development do-not-reply at isc.org
Mon Feb 25 13:38:22 UTC 2013


#2386: support generic version of rdata::createRdata(text) in NSEC, DS RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130305
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => muks


Comment:

 Replying to [comment:13 muks]:
 > Replying to [comment:11 jinmei]:
 > > I don't remember why I wrote that test, but while working on #2389
 > > I realized this may be a bit subtle.  In cases like A or AAAA, where
 > > we would expect a single, ascii-numeric string that would be converted
 > > by another helper function, beginning or trailing space would make it
 > > an invalid form.  In #2389 I decided to not use lexer for the string
 > > version, so (unless we change that due to review) this is still the
 > > case.  For other types, especially for complex ones like NSEC, I think
 > > it's okay to be flexible by allowing begin/trail spaces, but I think
 > > it's worth noting in documentation.
 >
 > Should the test be removed? What documentation change has to be made?
 Change the API doc to say that whitespace is allowed?

 Wasn't this already documented?

 {{{
 /// The given string must represent a valid NSEC RDATA.  There
 /// can be extra space characters at the beginning or end of the
 /// text (which are simply ignored), but other extra text, including
 /// a new line, will make the construction fail with an exception.
 }}}

 If we have no plan on re-enabling the test, then we should just remove it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2386#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list