BIND 10 #2689: Investigate work needed for removing threads from stats tests

BIND 10 Development do-not-reply at isc.org
Mon Feb 25 17:12:47 UTC 2013


#2689: Investigate work needed for removing threads from stats tests
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  statistics    |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130305
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:12 jelte]:

 > Technically not running is only one of the causes of timeouts (the worse
 one being a module that is running but going into an eternal loop when
 creating an answer, or running but not answering), so I don't think it
 should simply pass if the show_processes rpc call fails. I would suspect
 it could 'safely' fail in that case as well, or at the very least log an
 error.
 >
 > But if we have a followup on this (it does say TODO there), i think it
 is OK for now.

 To be sure, you're talking about this part, right?

 {{{#!python
     def do_polling(self):
         # ...
         try:
             value = self.mccs.rpc_call('show_processes', 'Init')
         except isc.config.RPCRecipientMissing:
             # This has been SessionTimeout before, so we keep the original
             # behavior.
             raise
         except isc.config.RPCError:
             # TODO: Is it OK to just pass? As part of refactoring,
 preserving
             # the original behaviour.
             value = None
 }}}

 It's not part of this branch; it was a change made by other task and
 is already merged in the master.  Besides, as noted in the "TODO"
 comment, this part of the code shouldn't change the original behavior;
 a timeout due to the remote module being in an infinite loop or too
 busy would still result in `SessionTimeout`, and it would still be
 propagated as before.

 I'm now planning to merge the branch, but if I misunderstand the
 comment please let me know.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2689#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list