BIND 10 #2600: DHCP Testing: V4 features - robustness

[BIND 10 Development]

#2600: DHCP Testing: V4 features - robustness
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:  tmark
                Type:  task          |                       Status:
            Priority:  medium        |  accepted
           Component:  dhcp          |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130228
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by tmark):

 I devised tests using Scapy to generate packets for the 3 types of tests
 listed in the test plan, under

 dchp-val/common/tests/v4.robustness:

 1. Testing that the server rejects everything but valid DHCP inbound
 packets:
   v4.valid_only.1.txt
   v4.valid_only.1.py

 2  Testing that the server rejects malformed packets
   v4.malformed_packets.1.py
   v4.malformed_packets.1.txt


 3. Testing that the server NAKs requests for unallocated/invalid addresses
   v4.improper_addresses.1.py
   v4.improper_addresses.1.txt


 The .py files can be submitted vi Scapy interactively to generate the test
 packets.
 Part of the review should double check the "expected" server responses as
 I'm not sure
 I have them all correct.

 Specifically examine the "unallocated" address tests.

 Additionally, without extensions/modification to Scapy it is pretty
 difficult to mal-form packets
 to any great extent.  Scapy does a lot to make sure things are structured
 correctly.
 This needs to be addressed at some point.

 The attached tarball has artifacts from the test runs.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2600#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development