BIND 10 #2389: support generic version of rdata::createRdata(text) in A, AAAA RDATA

[BIND 10 Development]

#2389: support generic version of rdata::createRdata(text) in A, AAAA RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130305
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:10 vorner]:

 > In the `convertToIPv4Addr`, and similarly in the IPv6 too, the error
 says „extra character“. But can it be more than one character? Or,
 actually, less characters, not more (so the extra would be confusing)? I
 don't see any reason why the inequality would have to be only in one
 direction.

 Ah, right.  I tried to make it more accurate.

 > In the tests, che `checkFromText`, could it be reused for both `A` and
 `AAAA`? If the type to create was a template argument too. Actually, I've
 seen similar method in some tests already. Maybe it is a good candidate
 for an utility function?

 That's one of the things I considered but skipped as my
 request-for-review comment, but as explicitly asked, I unified the
 cases.  I also unified the similar test for SOA (which I guess you
 meant by the "similar method").

 > Should the tests check the lexer exceptions are propagated through? Like
 providing text like ")192.0.2.1"?

 Okay, added.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2389#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development