BIND 10 #2389: support generic version of rdata::createRdata(text) in A, AAAA RDATA

BIND 10 Development do-not-reply at isc.org
Tue Feb 26 08:21:23 UTC 2013


#2389: support generic version of rdata::createRdata(text) in A, AAAA RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130305
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:11 jinmei]:
 > > In the `convertToIPv4Addr`, and similarly in the IPv6 too, the error
 says „extra character“. But can it be more than one character? Or,
 actually, less characters, not more (so the extra would be confusing)? I
 don't see any reason why the inequality would have to be only in one
 direction.
 >
 > Ah, right.  I tried to make it more accurate.

 Actually, you described a more concrete situation than before, while I
 worried if it can be more generic. What I mean is, if I call:

 {{{#!c++
 uint32_t destination;
 convertToIPv4Addr("192.0.2.1", 2, &destination);
 }}}

 Then it will throw, but the exception text is wrong. There's no extra nul,
 the length just doesn't match. Now, I expect such call may never happen
 for some reason. But if so, an explaining comment why it can't happen and
 why the situation with nul can would be nice.

 Anyway, I think such a comment is minor enough to just merge it
 afterwards.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2389#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list