BIND 10 #2440: add support for "merging" RRsets into memory::RdataSet

[BIND 10 Development]

#2440: add support for "merging" RRsets into memory::RdataSet
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130305
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  6             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 > Could you be more specific about which part of the code you're
 > referring to?

 I seem to be somewhat distracted lately, I even forget to paste the bit of
 code :-|. Anyway, here it is:

 {{{#!c++
     size_t total_len = 0;
     RdataReader reader(rrclass, rrtype, old_data, old_rdata_count,
                        old_sig_count,
                        boost::bind(decodeName, _1, _2,
 &impl_->olddata_buffer_,
                                    &total_len),
                        boost::bind(decodeData, _1, _2,
 &impl_->olddata_buffer_,
                                    &total_len));
     while (reader.iterateRdata()) {
         util::InputBuffer ibuffer(impl_->olddata_buffer_.getData(),
                                   impl_->olddata_buffer_.getLength());
         impl_->rdatas_.insert(createRdata(rrtype, rrclass, ibuffer,
 impl_->olddata_buffer_.getLength()));
         impl_->olddata_buffer_.clear();
     }
     impl_->old_data_len_ = total_len;

     total_len = 0;
     while (reader.iterateSingleSig()) {
         util::InputBuffer ibuffer(impl_->olddata_buffer_.getData(),
                                   impl_->olddata_buffer_.getLength());
         impl_->rrsigs_.insert(createRdata(RRType::RRSIG(), rrclass,
 ibuffer,
 impl_->olddata_buffer_.getLength()));
         impl_->olddata_buffer_.clear();
     }
     impl_->old_sig_len_ = total_len;
 }}}

 The rest seems OK.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2440#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development