BIND 10 #2389: support generic version of rdata::createRdata(text) in A, AAAA RDATA

[BIND 10 Development]

#2389: support generic version of rdata::createRdata(text) in A, AAAA RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130305
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  1.02          |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:13 vorner]:

 > > > In the `convertToIPv4Addr`, and similarly in the IPv6 too, the error
 says „extra character“. But can it be more than one character? Or,
 actually, less characters, not more (so the extra would be confusing)? I
 don't see any reason why the inequality would have to be only in one
 direction.
 > >
 > > Ah, right.  I tried to make it more accurate.
 >
 > Actually, you described a more concrete situation than before, while I
 worried if it can be more generic. What I mean is, if I call:

 I don't think it necessarily "more concrete", because the new text
 also covers the case where the given text is "more broken" in that it
 contains an intermediate nul without which it would be a valid textual
 representation, e.g., "192.0<nul>.2.1".  But anyway,

 > {{{#!c++
 > uint32_t destination;
 > convertToIPv4Addr("192.0.2.1", 2, &destination);
 > }}}

 > Then it will throw, but the exception text is wrong. There's no extra
 nul, the length just doesn't match. Now, I expect such call may never
 happen for some reason. But if so, an explaining comment why it can't
 happen and why the situation with nul can would be nice.

 now I understood what you really meant.  And, that actually shouldn't
 happen in the context this function is called.  I clarified that point
 in additional comments.

 > Anyway, I think such a comment is minor enough to just merge it
 afterwards.

 Okay, thanks, I've merged it with the revised comment.  Now closing
 the ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2389#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development