BIND 10 #2524: Add logging to files in libdhcpsrv

[BIND 10 Development]

#2524: Add logging to files in libdhcpsrv
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  task          |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130103
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen


Comment:

 Replying to [comment:5 stephen]:

 > The first time through the loop, "access" is empty. Hence
 "!access.empty()" is false, and > the space is not appended. On the second
 and subsequ....

 You're right. I got lost in my reading of the code ... :-)


 > > '''lease_mgr_factory.cc'''
 > > There is no need to initialize the access object explicitly to an
 empty string as the constructor does that anyway.
 > True, but explicitly initialising it to an empty string clearly
 indicates what the value is before it enters the loop.

 In this case, why don't you add a comment saying that the loop starts with
 an empty string? In the worst case (if a code is not optimized by a
 compiler), not only the constructor is called but also the assignment
 operator which generates an overhead.

 ----

 Any ChangeLog entry that should be reviewed?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2524#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development