BIND 10 #2433: implement validateZone, base part

[BIND 10 Development]

#2433: implement validateZone, base part
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130108
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 First, independently from the points below, I merged a new version of
 trac2432 as it affects this branch (commit 9a2fd23).  The merge
 succeeded cleanly, but I needed to update the branch due to the API
 changes at commit 28f3867.

 Replying to [comment:13 vorner]:

 > I see two minor issues. First, would it be reasonable to make the
 > `nullCallback` public? What if someone wanted to get all the errors and
 none of
 > the warnings?

 Hmm, on thinking about it, I guess we should simply allow empty
 callback functors.  Then just NULL suffices instead of the explicit
 `nullCallback`.  And, to this end, I don't see the need for having the
 default constructor any more (it would still save some typing if the
 caller really wants to callbacks completely, but in the case of zone
 checks (not just loading) it would be a rare case).  So I deprecated
 it, too.

 > The other, the „trivial wrapper“ `CallbackWrapper has 21 lines, which is
 a bit
 > too much to be trivial and bit too much to remember single boolean
 variable.
 > Wouldn't it be easier to create another Callbacks object and pass a
 function
 > modifying a boolean on stack there?

 I've updated it to avoid the wrapper class.  The amount of the
 additional code doesn't seem to be much reduced, but I have no
 objection to the suggestion per se.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2433#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development