BIND 10 #2433: implement validateZone, base part

BIND 10 Development do-not-reply at isc.org
Fri Jan 4 12:40:51 UTC 2013


#2433: implement validateZone, base part
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130108
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 I fixed a small compilation error on my system in tests. GCC seems to
 require
 the method passed to boost::bind to be public.

 Replying to [comment:14 jinmei]:
 > > The other, the „trivial wrapper“ `CallbackWrapper has 21 lines, which
 is a bit
 > > too much to be trivial and bit too much to remember single boolean
 variable.
 > > Wouldn't it be easier to create another Callbacks object and pass a
 function
 > > modifying a boolean on stack there?
 >
 > I've updated it to avoid the wrapper class.  The amount of the
 > additional code doesn't seem to be much reduced, but I have no
 > objection to the suggestion per se.

 I'd suggest two things here:
  * Avoid making copy of the callbacks.
  * Remove the warn wrapper, it is possible to call directly by
 `boost::bind`.

 Both suggestions are committed to the branch. If you don't agree with any
 of
 them, feel free to remove them from the history.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2433#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list