BIND 10 #2535: handle escaped characters in TXTLikeImpl::toText

BIND 10 Development do-not-reply at isc.org
Mon Jan 7 05:35:16 UTC 2013


#2535: handle escaped characters in TXTLikeImpl::toText
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  closed
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130108
           Sensitive:  0             |                   Resolution:  fixed
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  1.58          |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to `master` branch in commit
 `f516fc484544b7e08475947d6945bc87636d4115`:
 {{{
 * 50e76dc [2535] Also check the returned rrset
 * 3e9a694 [2535] Test that TXTLike data is escaped correctly when written
 to database
 * a6ce7e4 [2535] Split up createSQLite3Client method
 * e17ddc8 Revert "[2535] Add a datasrc test for escaping txt-like rdata"
 * 8960a57 [2535] Unify test code
 * 3ff7531 [2535] Rename function to stringToCharString()
 * 376b3b0 [2535] Add a datasrc test for escaping txt-like rdata
 * 27e7210 [2535] Use charStringToString() in TXTLike
 * 230078e [2535] Reindent code
 * 77b42ea [2535] Add charStringToString() to convert a CharString to a DNS
 textual representation
 * 31a4bc5 [2535] Add a ch variable to make code more readable
 * 89f331d [2535] Add comment about the \xxx escaped format
 * c6c569c [2535] Replace 0x30 with '0' to make code more readable
 * 772ce4c [2535] Handle escaped characters in TXTLikeImpl::toText()
 }}}

 I also pushed the following additional commits to the `master` branch:
 {{{
 * e5a3546 [2535] Update loadzone test data for newly added escaping
 * a92495c [2535] Add ChangeLog
 }}}

 `make check` and lettuce pass.

 Resolving as fixed. Thank you for the reviews Michal and Jinmei.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2535#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list