BIND 10 #2608: msgq process stays around

[BIND 10 Development]

#2608: msgq process stays around
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:
                       Type:         |                Status:  new
  defect                             |             Milestone:  Next-Sprint-
                   Priority:         |  Proposed
  medium                             |              Keywords:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  Core
               CVSS Scoring:         |  Estimated Difficulty:  0
            Defect Severity:         |           Total Hours:  0
  Medium                             |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 I discovered that on a slow system, boss will sometimes be unable to
 connect to msgq in time, and will shut down. This happens during the
 Lettuce tests on a Raspberry Pi, for example.

 There is a bug, when the happens, which means that the msgq process is not
 shut down. The following change will perform this cleanup properly.

 {{{
 #!python
 diff --git a/src/bin/bind10/bind10_src.py.in
 b/src/bin/bind10/bind10_src.py.in
 index 882653b..3054d74 100755
 --- a/src/bin/bind10/bind10_src.py.in
 +++ b/src/bin/bind10/bind10_src.py.in
 @@ -443,6 +443,8 @@ class BoB:

              # if we have been trying for "a while" give up
              if (time.time() - cc_connect_start) > self.msgq_timeout:
 +                if msgq_proc.process:
 +                    msgq_proc.process.kill()
                  logger.error(BIND10_CONNECTING_TO_CC_FAIL)
                  raise CChannelConnectError("Unable to connect to
 c-channel afte

 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2608>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development