BIND 10 #2437: python wrapper for validateZone
BIND 10 Development
do-not-reply at isc.org
Mon Jan 7 14:16:19 UTC 2013
#2437: python wrapper for validateZone
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130108
Sub-Project: DNS | Resolution:
Estimated Difficulty: 3 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
Is the code really only a single commit (and a bunch of merges before)?
I'm
just making sure I checked everything.
Also, few small points.
The constructor of tests, it is counter-intuitive for `find_result=False`
to
mean „act normally“. I'd propose `None`, but it is actually used to be
returned
somewhere. But even `True` might be better.
We should test throwing from the callbacks (since the exception must be
manually carried through a bunch of python←→C++ layers). It would be nice
if
the actual exception would be preserved, which is, I think, possible.
With the optional parameters, does it initialize them to NULL (or,
`Py_None`)
or leaves them as they are? In the second case, the variables could be
used
uninitialized:
{{{#!C++
PyObject* po_name;
PyObject* po_rrclass;
PyObject* po_rrsets;
PyObject* po_error;
PyObject* po_warn;
if (PyArg_ParseTuple(args, "OOO(OO)", &po_name, &po_rrclass,
&po_rrsets, &po_error, &po_warn)) {
}}}
And, I fixed a missing `EXTRA_DIST`, it is pushed to the branch.
--
Ticket URL: <http://bind10.isc.org/ticket/2437#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list