BIND 10 #2432: define and implement base and libdns++ version of RRsetCollection

[BIND 10 Development]

#2432: define and implement base and libdns++ version of RRsetCollection
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  closed
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130108
           Sensitive:  0             |                   Resolution:  fixed
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  5             |              Defect Severity:  N/A
         Total Hours:  3.84          |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to `master` branch in commit
 `0de32e7fe21e18069d26e3d282ac8078c852f004`:
 {{{
 * 806865c [2432] Fix more cases of \return (use singular form)
 * e7f9ab5 [2432] Use prefix operator++
 * 35d0201 [2432] Minimize code
 * 0048238 [2432] Use ASSERT_TRUE to not crash test suite in some places
 * 1fa6947 [2432] Fix use of \return (use singular form)
 * 3baea8c [2432] Use \throws in API doc
 * 08c2f82 [2432] Remove explicit template instantiation in one case
 * dd44433 [2432] Remove RRsetCollection::find() that returns an
 AbstractRRset
 * 5d3af5f [2432] Add some more API doc
 * bbb8a8f [2432] Use RRCollator during RRsetCollection construction (zone-
 loading)
 * ee424bb [2432] Move common code into a helper method
 * bdf19ad [2432] Return status in removeRRset()
 * cfbb9ea [2432] Document whether rrsets can be modified after being added
 * 8bca74f [2432] Document the state of the collection for empty
 constructor
 * 3492997 [2432] Rename iterator class to Iterator
 * 98d515d [2432] Add a RRsetCollection constructor that takes an
 std::istream
 * 4a15ebc [2432] Add more API documentation
 * 8f149bd [2432] Add API doc for equals() about incompatible types
 * 2016723 [2432] Add rrset_collection{,_base}.h to libdns++ installed
 headers
 * fc88231 [2432] use EXPECT_TRUE and ==/!= instead of EXPECT_EQ/NE
 iterators
 * 82d0b7f [2432] Explain ownership of rrset passed to addRRset()
 * 2205f81 [2432] Add virtual destructor
 * a9c8b8f [2432] Untabify
 * 12b2454 [2432] Don't throw when comparing iterators from different
 RRsetCollectionBase implementations
 * 0a14dac [2432] Untabify
 * 9cb41a2 [2432] Throw during addRRset() if an rrset with the given class,
 type and name already exists
 * 7383457 [2432] Add zero-argument RRsetCollection constructor
 * e6c05e2 [2432] Remove iter variable
 * b573583 [2432] Move addAndRemove test code to a helper method
 * e4a823a [2432] Change equality check style
 * 6c738ab [2432] Add tests for absent RRClass
 * 7eee122 [2432] Add RRClass too in the RRsetCollection key, and make
 find() search for them
 * b5aa1d1 [2432] Unify common test code
 * 2fc0ce2 [2432] Update comment about ignoring error and warning callbacks
 * d33dd12 [2432] Remove the empty rrset_collection_base.cc file
 * c645605 [2432] Add RRsetCollectionBase, and an implementation of
 RRsetCollection
 }}}

 Resolving as fixed. Thank you for the reviews Michal and Jinmei.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2432#comment:36>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development