BIND 10 #2313: Custom namespaces (including vendor spaces)

[BIND 10 Development]

#2313: Custom namespaces (including vendor spaces)
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  task          |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130122
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 reviewed commit 3e100854e0a85d215d614729f6d429340be1ead2

 '''src/lib/dhcpsrv/option_space.cc'''[[BR]]
 Line 33: s/Allowed digits/Allowed characters/

 validateName(): Is a name beginning with a hyphen allowed? (I can see the
 code allows its, but semantically, is it allowed?)

 '''src/lib/dhcpsrv/option_space.h'''[[BR]]
 s/disencouraged/discouraged/

 In the header for !OptionSpace, suggest when talking about OptionSpace6,
 you mention that it extends the !OptionSpace class.  (My first thought was
 "why not call the V4 class OptionSpace4 for symmetry.)

 Would be logical to group clearVendorSpace() with isVendorSpace() and
 setVendorSpace() (instead of having getName() between them.)

 The documentation seems to imply that the "vendor space" attribute is only
 relevant in V6, but that it is in !OptionSpace (and not OptionSpace6)
 because of the convenience of being able to point to OptionSpace6 objects
 with a pointer to !OptionSpace.  If thid is correct, can the documentation
 for the xxxVendorSpace() methods make that clear (perhaps group the
 methods using the Doxygen "!///@{" construct and attach documentation to
 the group).  Also clarify that point in the header for the OptionSpace6
 class.

 '''src/lib/dhcpsrv/tests/option_space_unittest.cc'''[[BR]]
 The optionSpace6 test creates only !OptionSpace objects, and no
 OptionSpace6 objects.  A mixture is required (as the !OptionSpace header
 suggests that both can represent a V6 Option Space).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2313#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development