BIND 10 #2437: python wrapper for validateZone
BIND 10 Development
do-not-reply at isc.org
Tue Jan 8 12:50:27 UTC 2013
#2437: python wrapper for validateZone
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130108
Sub-Project: DNS | Resolution:
Estimated Difficulty: 3 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
Replying to [comment:6 jinmei]:
> > The constructor of tests, it is counter-intuitive for
`find_result=False` to
> > mean „act normally“. I'd propose `None`, but it is actually used to be
returned
> > somewhere. But even `True` might be better.
>
> Okay, I changed it to a string 'use_default'. It should be clearer.
That's slightly better.
> > We should test throwing from the callbacks (since the exception must
be
> > manually carried through a bunch of python←→C++ layers). It would be
nice if
> > the actual exception would be preserved, which is, I think, possible.
>
> Hmm, I'm not sure what specifically you are suggesting. Is this
> something not covered in test_check_callback_fail?
Sorry, I overlooked it previously. This is exactly what I asked for O:-).
> There's no optional parameter here. If you meant the "(OO)" part,
> it means it's a tuple of two objects. Nevertheless, I don't mind
> setting the po_xxx to NULL f you want.
OK, then. It should be OK in this case.
So I think it can be merged.
--
Ticket URL: <https://bind10.isc.org/ticket/2437#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list