BIND 10 #2436: update datasrc::ZoneLoader so it performs post load checks using validateZone()

[BIND 10 Development]

#2436: update datasrc::ZoneLoader so it performs post load checks using
validateZone()
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:10 jinmei]:
 > I don't know if it's a "trick", but, yes, it can.  According to C++ 2003
 > spec: (in Section 12.2 "Temporary objects") "There are two contexts in
 > which temporaries are destroyed at a different point than the end of
 > the full-expression....The second context is when a reference is bound
 > to a temporary. The temporary to which the reference is bound or the
 > temporary that is the complete object to a subobject of which the
 > temporary is bound persists for the lifetime of the reference except
 > as specified below."  (the exceptions don't apply to our case).

 OK, changed.

 > You can easily confirm it (at least that it works that way with your
 > compiler) by writing a simple test program.  Besides, there are
 > already many such cases in our code.

 Well, I had enough of memory-corruption bugs that worked sometimes (with
 some
 compilers, with enabled debug information, with just some versions of
 compiler)
 that I wouldn't even consider that experiment to be safe. I'd agree on
 trusting
 it to prove something does _not_ work, but not the other way around.

 > In that case, the TODO isn't clear enough to me.  I'd rephrase it like
 > this:

 I modified it little bit. The failing isn't the only concern of the
 comment. If
 the prepareSource used ZoneLoader internally, it wouldn't test much.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2436#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development