BIND 10 #2572: extend MasterLexer to provide current/total bytes of source(s)
BIND 10 Development
do-not-reply at isc.org
Thu Jan 10 16:35:23 UTC 2013
#2572: extend MasterLexer to provide current/total bytes of source(s)
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130122
Sub-Project: DNS | Resolution:
Estimated Difficulty: 4 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => jinmei
Comment:
Very general question/consideration; do we want to support being able to
read from inputs where file size is undefined? (i.e. not error on -1 but
just report 'unknown' so that you can, for instance, pipe cin to parse
from?)
master_lexer.h:
getPosition: the note about 'if a source is pushed, this method will
normally return a smaller number', is that 'when a source is pushed due to
encountered data like the $INCLUDE directive' (which has an unget
somewhere)? If so it might make sense, otherwise i don't see how the
position would move back, or am I misunderstanding something here?
Code itself looks ok
--
Ticket URL: <https://bind10.isc.org/ticket/2572#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list