BIND 10 #2435: implement datasrc version of RRsetCollection

BIND 10 Development do-not-reply at isc.org
Thu Jan 10 18:17:44 UTC 2013


#2435: implement datasrc version of RRsetCollection
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 One quick point related to the interface: why does this return a
 shared pointer?
 {{{#!cpp
     virtual isc::dns::RRsetCollectionPtr getRRsetCollection() = 0;
 }}}

 Since the returned collection essentially belongs to the creating
 updater (as the doc of the method even says), I don't see the reason
 for sharing the ownership.  I'd rather be afraid that sharing the
 ownership would give the false sense of lifetime relationship, i.e.,
 it could look as if the caller can maintain the collection object as
 long as it wants.

 Is there a reason that it cannot be a bare pointer or a reference?

-- 
Ticket URL: <https://bind10.isc.org/ticket/2435#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list