BIND 10 #2498: support generic version of rdata::createRdata(text) in HINFO and NAPTR

[BIND 10 Development]

#2498: support generic version of rdata::createRdata(text) in HINFO and NAPTR
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  jelte
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130122
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 Replying to [comment:9 jelte]:
 > Replying to [comment:8 vorner]:
 > > And this one looks wrong. AFAIK charStringToString already does
 escaping. It would therefore generate both quotes and escape sequences,
 which is duplicate (indeed, the previous version was wrong too):
 >
 > It's not escaping, it's requoting the quoted string, which has been
 stripped by the parser; it'll quote unquoted input, but that's just having
 more strict output than input :) Added a couple of tests to make sure it
 isn't doing it twice

 OK, it seems I was wrong there. But can you add another one, to check the
 quotes are well escaped and spaces are not over-escaped, and such?
 Something like?

 {{{#!c++
 EXPECT_EQ("\"a\\\"\" \"b c\"", HINFO("\"a\\\"\" \"b c\"").toText());
 }}}

 Also, I think this should not have been left in the code:
 {{{#!c++
 void HINFO::ptr() const {
     std::cout << "[XX] PTR: " << impl_.get() << std::endl;
 }
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2498#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development