BIND 10 #680: awkward [TEMP MESSAGE] from bindctl

BIND 10 Development do-not-reply at isc.org
Mon Jan 14 14:13:16 UTC 2013


#680: awkward [TEMP MESSAGE] from bindctl
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  jelte
                Type:  defect        |                       Status:
            Priority:  medium        |  assigned
           Component:  bind-ctl      |                    Milestone:
            Keywords:                |  Sprint-20130122
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  1             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by shane):

 * owner:  shane => jelte
 * status:  accepted => assigned


Comment:

 The login_to_cmdctl() function should probably have comments in the code
 explaining the logic:

 {{{
 #!python
 # look at each saved username/password and try to log in
 users = self._get_saved_user_info(self.csv_file_dir, CSV_FILE_NAME)
    .
    .
    .
 # no valid logins were found, so prompt the user for a username/password
 count = 0
 }}}

 Also, I recommend we refer to the section names instead of numbers, since
 the numbers can move around depending on the document re-structure in XML.
 We might also want to add a URL, although that might be inappropriate for
 certain environments:

 {{{
 #!python
 nologinmsg="""No stored password file found. Please see "Configuration
 specification
 for b10-cmdctl" and "bindctl command-line options" in the BIND 10 Guide:
     http://bind10.isc.org/docs/bind10-guide.html#cmdctl.spec
 http://bind10.isc.org/docs/bind10-guide.html#bindctl_commandline_options"""
 }}}

 I'm happy if this gets merged without these changes, with some of them, or
 with all of them.

-- 
Ticket URL: <http://bind10.isc.org/ticket/680#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list