BIND 10 #2587: investigate and fix AuthSrvTest.DDNSForward regression on NetBSD

[BIND 10 Development]

#2587: investigate and fix AuthSrvTest.DDNSForward regression on NetBSD
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  b10-auth      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 Found it, this NetBSD is a tad stricter on the contents of the sockaddr
 struct when calling getnameinfo().

 ASIO does not set the sa_len field, and most BSD's don't care (linux
 doesn't even have it). But getnameinfo() on this system will fail if it
 isn't set.

 Proposed fix makes a non-const copy of the sockaddr struct, and if sa_len
 is available, it is set.

 I also piggybacked a small unit test memory leak in srv_test.cc

-- 
Ticket URL: <http://bind10.isc.org/ticket/2587#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development