BIND 10 #2572: extend MasterLexer to provide current/total bytes of source(s)

[BIND 10 Development]

#2572: extend MasterLexer to provide current/total bytes of source(s)
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  high          |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  5.25          |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jinmei


Comment:

 Hi Jinmei

 Here are my review comments:

 * `getStreamSize()` seems to orchestrate seeking forward and backward and
 returns either `MasterLexer::SOURCE_SIZE_UNKNOWN` or an exception based on
 where (at what step of the entire orchestration) it fails. From my
 reading, it seems that in case it is unable to seek back to the start of
 the stream, it will throw an exception which seems correct. But
 `InputSourceTest.getSize` only seems to check up to the initial `.bad()`
 and `.fail()` checks at the start of `getStreamSize()` whereas the throws
 later in that method seem important to check too. Is it possible to test
 them somehow?

 * I have pushed a minor comment update commit to the branch. Please check
 it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2572#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development