BIND 10 #2597: DHCP server must store a server ID

[BIND 10 Development]

#2597: DHCP server must store a server ID
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:  tomek
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp          |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130122
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tomek


Comment:

 Reviewed commit 695d9fc3bc135de080369b0b7213aca3c264216c

 '''!ChangeLog'''[[BR]]
 Suggest a slight change:
 {{{
 b10-dhcp4/b10-dhcp6: The DHCP server now generates a server identifier
 the first time it is run.  The identifier is preserved in a file across
 server restarts.
 }}}

 '''doc/guide/bind10-guide.xml'''[[BR]]
 Some changes made and pushed.


 '''src/bin/dhcp4/dhcp4_messages.mes'''[[BR]]
 '''src/bin/dhcp6/dhcp6_messages.mes'''[[BR]]
 Some changes made and pushed.

 '''src/bin/dhcpX/dhcpX_srv.{cc,h}'''[[BR]]
 I feel that it would be more logical for the server ID to be a separate
 class.  It would be easier to test, as well as removing the minutiae of
 server ID manipulation from the DHCP server class.

 The DhcpvXSrv constructors call the methods that create the server ID.
 Some of these can throw exceptions.  At the very least, the constructor
 should catch the exception, print out an error message and re-throw the
 exception.

 '''src/bin/dhcp4/dhcp4_srv.cc'''[[BR]]
 loadServerID()/generateServerID(): IOAddress has been extended to include
 an isV4() method (saves comparing the family against AF_INET).

 '''src/bin/dhcp4/dhcp4_srv.h'''[[BR]]
 Description of the SERVER_ID_FILE talks about a DUID: copy/paste error?

 '''src/lib/dhcpsrv/cfgmgr.cc'''
 !CfgMgr constructor:
 Suggest the comment is strengthened to "must be set" and add something
 like "Note: the definition of DHCP_DATA_DIR needs to include the quotation
 marks".

-- 
Ticket URL: <http://bind10.isc.org/ticket/2597#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development