BIND 10 #2608: msgq process stays around

[BIND 10 Development]

#2608: msgq process stays around
-------------------------------------+-------------------------------------
            Reporter:  shane         |                        Owner:  shane
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  Unclassified  |                    Milestone:
            Keywords:                |  Sprint-20130122
           Sensitive:  0             |                   Resolution:
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  2             |              Defect Severity:
         Total Hours:  0             |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:   => shane
 * status:  new => reviewing


Comment:

 Since there is already a patch, I'm jumping straight to review :)

 Ideally, we'd make ProcessInfo a Context class (where __exit__=kill), so
 that it's killed on any exception, not just this particular case). but I
 guess that'll be too much changes for this particular fix, and as such, I
 have confirmed it works as expected.

 Tried shortly to see if we can make a test for it (since we do test it
 raises here) but the object is already gone by then, so I'm not sure how
 to.

 Please merge this, does it need a changelog? (e.g. [bug] boss now kills
 the msgq process it spawns if it cannot immediately connect to it, or
 something).

 BTW, one note about the diff; be careful when pasting git diff output from
 a terminal; as you can see it has the tendency to crop long lines. In this
 particular case the diff was simple and there were no problems applying
 it, and in most cases our lines aren't long anyway, but I have seen
 problems with the cropped diffs

-- 
Ticket URL: <http://bind10.isc.org/ticket/2608#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development