BIND 10 #2587: investigate and fix AuthSrvTest.DDNSForward regression on NetBSD

[BIND 10 Development]

#2587: investigate and fix AuthSrvTest.DDNSForward regression on NetBSD
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  b10-auth      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 It basically looks okay.  (I've not checked it on the netbsd box,
 but the explanation makes sense, and I'm assuming you confirmed it on
 it.)

 A couple of minor points:

 - in auth_srv_unittest.cc, you can use convertSockAddr to convert
   sockaddr_storage* to sockaddr*:
 {{{#!cpp
     struct sockaddr* sa = convertSockAddr(&ss);
 }}}
   (it does the same thing as the original code; it's just convenient
 shortcut).
 - the fix to memory leak looks correct, but I wonder we might rather
   switch to scoped_ptr at this opportunity.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2587#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development