BIND 10 #2587: investigate and fix AuthSrvTest.DDNSForward regression on NetBSD
BIND 10 Development
do-not-reply at isc.org
Thu Jan 17 16:10:31 UTC 2013
#2587: investigate and fix AuthSrvTest.DDNSForward regression on NetBSD
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | jinmei
Priority: medium | Status:
Component: b10-auth | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130122
Sub-Project: DNS | Resolution:
Estimated Difficulty: 3 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
I made one minor editorial change.
It can be merged, with a couple of minor additional points:
- I guess we can even remove the explicit definition of `~SrvTestBase`.
`::testing::Test` should have a virtual destructor, and that should
be enough.
- I'd explicitly include scoped_ptr.hpp in srv_test.cc, too, instead
of relying on that it's included in srv_test.h
But I'd leave these points to you, and either way I don't think I need
to re-review it. So, please merge with or without (any of) these.
--
Ticket URL: <http://bind10.isc.org/ticket/2587#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list