BIND 10 #2573: extend MasterLoader and ZoneLoader to return additional states including # of loaded RRs
BIND 10 Development
do-not-reply at isc.org
Fri Jan 18 11:31:42 UTC 2013
#2573: extend MasterLoader and ZoneLoader to return additional states including #
of loaded RRs
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130122
Sub-Project: DNS | Resolution:
Estimated Difficulty: 4 | CVSS Scoring:
Total Hours: 2.03 | Defect Severity: N/A
| Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
* totalhours: 1.81 => 2.03
Comment:
Hello
Replying to [comment:9 jinmei]:
> The changes are basically trivial, but not one-liner type of update,
> so I'm giving the ticket back to you.
Just to ask, is it safe to use equality on the 0 and 1 (in tests)? Should
we use EXPECT_DOUBLE_EQ there too?
> > * If the `PROGRESS_UNKNOWN` was something large instead, we could use
`unsigned`. Wouldn't it be better?
>
> I don't have a strong opinion, but using a minus has its own advantage
> that it's much less likely to conflict with any future changes of the
> valid range. Also, now that it's double, I guess making the return
> value unsigned does not matter much. At the moment I've kept it as
> is.
Non-negative with double doesn't bring any advantage (and I don't think a
double can be made unsigned anyway). I'm not completely sure how C++
handles `NaN` values, but this could be a nice place to use one, actually.
Anyway, that's just too minor thing, no need to worry about it.
> BTW, as for your editorial changes: Putting two space characters as a
> sentence separator was intentional. I believe that's actually a
> common style of English writing (just like in this particular ticket
> comment). But I don't mind using a single space (and those comments
> are not formal English text anyway), so I didn't touch it.
Actually, I wasn't correcting the spaces there, I didn't think about these
(only about the one before comma). They were the lower-case letters that I
was fixing, and I probably removed the second space when editing it. When
you mention the convention, I do know some people do that, it's just I'm
not used to it.
Anyway, please, merge it.
--
Ticket URL: <http://bind10.isc.org/ticket/2573#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list