BIND 10 #2559: Obtain DHCP lease database parameters from configuration database

[BIND 10 Development]

#2559: Obtain DHCP lease database parameters from configuration database
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcpdb        |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130122
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by stephen):

 > General: the modified and new files should have copyright headers
 updated to 2013:
 Well spotted - changed.

 > '''src/bin/dhcp4/config_parser.cc'''
 > '''src/bin/dhcp6/config_parser.cc'''
 > Line 1386: since the current_parser variable has been introduced it
 makes sense to use it further in the code rather than config_pair.first,
 e.g.
 On reflection, it seemed better to remove current_parser and instead make
 config_pair the variable accessible from the catch clause.  It is has been
 declared before the "try" block, and the declarations in the BOOST_FOREACH
 clauses removed.

 > DbAccessParser::build: suggest that you consider using std::swap() to
 assign contents of the values_copy to values_ when the parsing is
 successful. In theory it should be faster than using the assignment
 operator.
 Again, well spotted.  Changed.

 > DbAccessParser::commit: spurious space before dbaccess.empty() in line
 91
 Removed.

 > '''src/lib/dhcpsrv/dbaccess_parser.h'''
 > !ConfigPair definition (line 48): this type could be declared private
 within this class as it is not used externally. Alternatively, could this
 be declared in the dhcp_config_parser.h and become common for all parsers?
 Moved to dhcp_config_parser.h

 > In the header of getDbAccessParameters function: s/corrected/correctly.
 Corrected.

 > '''src/lib/dhcpsrv/dhcpsrv_messages.mes'''
 > Suggest that the following warning message...
 Warning message changed.

 > '''src/lib/dhcpsrv/tests/dbaccess_parser_unittest.cc'''
 > There are no tests for commit() function.
 The code for creating the databqase access string has been broken into a
 separate method and a test added for it.  A test for commit() has also
 been added.

 > Do you need to:
 > #include <fstream>
 > :
 No - result of cut-and-paste.  Redundant #includes removed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2559#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development