BIND 10 #2637: DHCP code tidy-up for the release in January 2013

[BIND 10 Development]

#2637: DHCP code tidy-up for the release in January 2013
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  task          |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130122
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => marcin


Comment:

 Replying to [comment:9 marcin]:
 > Replying to [comment:7 tomek]:
 > > '''src/bin/dhcp4/config_parser.cc'''
 > > createOption() verifies if the option_name contains spaces. Why this
 specific case is checked here, but all other checks are done in
 OptionSpace::validateName?
 >
 > The OptionSpace::validateName is validating option space name while the
 createOption checked the option name for emptiness. These are two
 different things being validated. In any case I added a static function
 OptionDefinition::validateName that is now used to validate option name.
 It's almost good now, but the second comment (line 767) is invalid:
 {{{
 // Check that the option name has been specified and that it is
 // valid.
 }}}
 It is option space, not option name here.

 Tests look good. Usage of typeid is quite clever.

 > Proposed !ChangeLog entry:
 > {{{
 > XXX.  [bug]           vorner
 >       Fixed DHCP servers configuration whereby the server did not
 >       receive a configuration stored in the database on its startup.
 >       Also, the configuration handler function now uses full
 configuration
 >       instead of partial to configure the server. This guarantees that
 >       dependencies between various configuration parameters are
 >       fulfilled.
 > }}}
 Make sure you include also Trac number and git commit-id. Otherwise it
 looks good, mr '''Vorner'''. ;-)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2637#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development