BIND 10 #2309: define ZoneFinder::findAtOrigin()
BIND 10 Development
do-not-reply at isc.org
Wed Jan 23 14:03:04 UTC 2013
#2309: define ZoneFinder::findAtOrigin()
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: data source | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130205
Sub-Project: DNS | Resolution:
Estimated Difficulty: 6 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
Is the copyright header year OK in the new file (zone_finder.h). I know
the code is just one taken from elsewhere, but it's new file on the other
hand. I'm not sure how these copyright matters work.
There might be needed a comma in this commend after RRTTL, this way it
looks like a minimum from 3 values:
{{{
// so we specify the use of min(RRTTL SOA MINTTL) as specified Section 3
}}}
Also, I'm not sure I really like the idea with having a public interface
just wrapping the `getAtOriginImpl`. Is it really likely the interface
would change in a way the implementation could stay the same? What is
special about this case so it is handled exceptionally? I don't know if
it's worth the added layer of complexity. I'm not worried about the speed
of produced code, it should be the same, since compiler will just inline
it and optimise the call out, but the complexity of following the code.
--
Ticket URL: <http://bind10.isc.org/ticket/2309#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list