BIND 10 #2435: implement datasrc version of RRsetCollection

BIND 10 Development do-not-reply at isc.org
Mon Jan 28 04:07:41 UTC 2013


#2435: implement datasrc version of RRsetCollection
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130205
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by muks):

 Replying to [comment:25 muks]:
 > I read the coding guidelines before making that change, and if you have
 > all of the discussion you will see I mentioned to Jelte that the empty
 > destructor declaration (with or without `virtual`) was unnecessary in
 > the derived classes. The coding guidelines aren't always complete or
 > have something I agree with, so I just follow whatever is specified for
 > consistency. From the discussion, I thought it was expected that we add
 > the virtual destructor to every derived class.

 I missed saying the actual point. We looked at the coding guidelines when
 reviewing that patch by Jelte, and there was nothing about this
 specifically in the coding guidelines. I guess there's nothing there
 because you'd expect not to include this empty destructor in every derived
 class. The point about adding `virtual` for other `virtual` derived
 methods was known.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2435#comment:26>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list