BIND 10 #2310: In-memory version of ZoneFinder::findAtOrigin()

[BIND 10 Development]

#2310: In-memory version of ZoneFinder::findAtOrigin()
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130205
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:12 jinmei]:
 > One alternative is to borrow wrapper functions of ASIO, but including
 > ASIO header files has its own risks.

 That doesn't sound really nice. Having our own is probably better for such
 a short function.

 > So, I'm personally okay with using the library functions, but that's
 > not about this specific case, and we should unify the policy and be
 > consistent throughout our code.  For now I didn't touch it.

 Can you add an explanation why we don't use the htonl, please?

 > Do you mean storing TTL in the form of RRTTL in `ZoneData`?  If so,
 > for in-memory it doesn't make much sense anyway because we mainly use
 > it only for wire-format rendering (`getTTL()` (and `toText()` which
 > uses the getTTL) isn't expected to be called except for rare cases).

 I don't mean all the TTLs. I meant the min_ttl one, because we construct
 the RRTTL every time it is requested, to be compared. But it's probably
 marginal, so we can ignore it.

 So, except for the comment about htonl, it is OK to merge. I don't think I
 need to see such simple comment, so merge afterwards.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2310#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development