BIND 10 #2390: support generic version of rdata::createRdata(text) in NS, MX, PTR RDATA

[BIND 10 Development]

#2390: support generic version of rdata::createRdata(text) in  NS, MX, PTR RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  jelte
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130205
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  4             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jelte


Comment:

 Hi Jelte

 Replying to [comment:14 jelte]:
 > Regarding things like '192.0.1.2': NS records with IP address targets
 > are not allowed by the protocol, but as it happens, '192.0.1.2(.)' is
 > also a valid domain name (by protocol, just not by policy in the
 > global namespace). So while it is technically 'correct' from a
 > parser's point of view, it is extremely likely to not mean what the
 > administrator intended. BIND 9 accepts it but gives a warning ('this
 > looks like an address, not a name' or something like that). I suspect
 > that in our unit test cases it is usually a copy/paste mistake that
 > happened to work for the intended purposes.

 What do we do about supporting IP addresses though? Shall we leave code
 as-is, or should we add any code to specificially handle them? (a
 trailing dot is not a valid IP address).

 > Code looks OK, just a few comments:
 >
 > mx_15.cc:73: add the 'bad' text to exception for out of bounds in mx?
 > (e.g. 'bad preference for mx: 100000')

 Added. :)

 > About the tests, one that is easy to add here while we're doing it is
 > to check the origin is appended in the createFromLexer cases. That's
 > at least the biggest one that seems to be missing for these types :)

 Added. :)

 Replying to [comment:15 jelte]:
 > Forgot to mention, I pushed a minor style fix in one of the python
 > test files, please verify.

 This looks good too.

 Also please remember to check that I write a `ChangeLog` for both this
 and #2656 before merging them. :)

-- 
Ticket URL: <https://bind10.isc.org/ticket/2390#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development