BIND 10 #2677: General clang issues

[BIND 10 Development]

#2677: General clang issues
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  stephen                            |                Status:  new
                       Type:         |             Milestone:  New Tasks
  defect                             |              Keywords:
                   Priority:         |             Sensitive:  0
  medium                             |           Sub-Project:  DNS
                  Component:  build  |  Estimated Difficulty:  0
  system                             |           Total Hours:  0
               CVSS Scoring:         |
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 Whilst addressing #2673, I also noticed the following warnings.  The
 environment was OSX 10.8 with clang 4.1:

 '''src/lib/config'''
 {{{
   CXX      ccsession.lo
 ccsession.cc:345:32: warning: '&&' within '||' [-Wlogical-op-parentheses]
             cur_name[0] == '*' && cur_name[1] == '.') {
             ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
 ccsession.cc:345:32: note: place parentheses around the '&&' expression to
 silence this warning
             cur_name[0] == '*' && cur_name[1] == '.') {
                                ^
 1 warning generated.
 }}}

 '''src/lib/asiodns'''
 {{{
   CXX      libb10_asiodns_la-udp_server.lo
 In file included from udp_server.cc:30:
 In file included from ../../../src/lib/asiolink/udp_socket.h:31:
 ../../../src/lib/asiolink/io_asio_socket.h:347:37: warning: unused
 parameter 'data' [-Wunused-parameter]
     virtual void asyncReceive(void* data, size_t, size_t, IOEndpoint*, C&)
 {
    :
 }}}
 (There are a number of these)

 {{{
   CXXLD    libb10-asiodns.la
 libtool: link: warning: `/opt/log4cplus/lib/liblog4cplus.la' seems to be
 moved
 clang: warning: argument unused during compilation: '-pthread'
 }}}
 The "-pthread" message appears at other points in the BIND 10 build, not
 just in src/lib/asiodns.

 {{{
   CXX      run_unittests-dns_server_unittest.o
 dns_server_unittest.cc:674:18: warning: expression result unused
 [-Wunused-value]
     EXPECT_THROW(TCPServer(this->service, 0, AF_UNIX, this->checker_,
     ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 /opt/gtest-1.5.0/include/gtest/gtest.h:1681:21: note: expanded from macro
 'EXPECT_THROW'
   GTEST_TEST_THROW_(statement, expected_exception,
 GTEST_NONFATAL_FAILURE_)
                     ^
        :
 }}}
 (There are a number of these)

 When dealing with unavoidable warnings in a particular part of the build,
 we should decide whether we disable that particular warning (e.g. -Wno-
 unused-parameters) or disable the promotion of warnings to errors (-Wno-
 error).

-- 
Ticket URL: <https://bind10.isc.org/ticket/2677>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development