BIND 10 #2673: some build related issues in dhcp

[BIND 10 Development]

#2673: some build related issues in dhcp
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130214
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * status:  assigned => reviewing


Comment:

 Reviewed commit 53dec20f027b589c2202f182a01d8e33ef15c2a9

 I built the code with clang 4.1 on a Mac and needed to make some changes
 (which I've pushed) to get rid of warnings:

 * The removal of the -Wno-unused-parameters flag was reversed.  Without
 this, the clang compilation failed in one of the boost files.

 * The SERVER_ID_FILE declaration was moved from dhcp{4,6}_srv.h to
 dhcp{4,6}_srv.cc to eliminate an "Unused Variable" warning/error when
 compiling one of the other source files in which this header file was
 indirectly included.

 * Two member variables in a class in src/bin/dhcp{6,4}/config_parser.cc
 were re-ordered to avoids a warning/error along the lines of "X will be
 initialized after Y"

 * A few unused arguments were commented out so that g++ compilation
 succeeded.

 A complete rebuild with clang 4.1 on OS X 10.8 succeeded (as did a rebuild
 with g++ 4.6.1 on Ubuntu 11.10).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2673#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development