BIND 10 #2855: introduce a "zone builder" thread in memory manager

BIND 10 Development do-not-reply at isc.org
Mon Jul 1 07:45:06 UTC 2013


#2855: introduce a "zone builder" thread in memory manager
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  shmem         |                    Milestone:
  manager                            |  Sprint-20130709
            Keywords:                |                   Resolution:
           Sensitive:  0             |                 CVSS Scoring:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  4             |  Feature Depending on Ticket:
         Total Hours:  2.80          |  shared memory data source
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks
 * totalhours:  0 => 2.80


Comment:

 Hello

 The code looks mostly OK.

 Sorry that I didn't notice this sooner, but you seem to use the clear()
 method of lists. That was added in python 3.3, you'll probably have to use
 something like `del self._builder_command_queue[:]` or similar. I think I
 glimpsed two occurrences of the use.

 But this is minor only, so please merge after that.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2855#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list