BIND 10 #2957: DHCP-DDNS: Develop the DHCP DDNS configuration manager class

[BIND 10 Development]

#2957: DHCP-DDNS: Develop the DHCP DDNS configuration manager class
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp-ddns     |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130703
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tmark


Comment:

 Reviewed commit 41d5b2ead11a334e89a7f04ab38571e2795083d0

 I've made two changes and pushed:

 '''d2_messages.mes''': The new description for DCTL_ORDER_NO_ELEMENT had
 lines that were too long. I've wrapped the lines.

 '''d_cfg_mgr_unittests.cc''': When I compiled on Ubuntu 12.04 I got the
 following error:
 {{{
   CXX    d2_unittests-d_cfg_mgr_unittests.o
 d_cfg_mgr_unittests.cc: In member function 'virtual void
 {anonymous}::DStubCfgMgrTest_simpleTypesTest_Test::TestBody()':
 d_cfg_mgr_unittests.cc:294:167: error: converting 'false' to pointer type
 for argument 1 of 'char
 testing::internal::IsNullLiteralHelper(testing::internal::Secret*)'
 [-Werror=conversion-null]
 cc1plus: all warnings being treated as errors
 }}}
 Changing:
 {{{
 EXPECT_EQ(false, actual_bool);
 }}}
 to
 {{{
 EXPECT_FALSE(actual_bool);
 }}}
 ... fixed the problem.

 > I have changed these two to return ::testingAssertionResult. This is
 much cleaner. Wasn't aware of this feature.
 Neither was I!

 > !ChangeLog
 Your suggestion is OK.


 All should be OK now, please merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2957#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development