BIND 10 #2884: per zone statistics must be separated per class

[BIND 10 Development]

#2884: per zone statistics must be separated per class
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  statistics    |                    Milestone:
            Keywords:                |  Sprint-20130709
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  8             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => muks


Comment:

 Hi Mukund-san,

 Thank you for reviewing!

 > * In `item_title` and `item_description`, I suggest you use "RR class
 >   name" as it's more indicative.

 I added "RR". Please see
 {{{
 6d1f4e1 [2884] s/class name/RR class name/ig
 }}}

 > * Is there any validation done for the RR class, i.e., that it must be
 >   in ['IN', 'CH', etc.]?

 No. If we want to restrict by the known names, e.g. IN, CH, and HS, we can
 choose a map type as another option. But in the case all of them are
 always shown even if any of them are never counted. So I chose the
 named_set by assuming another new class name would be added in future.

 > * Please rewrite the following code in `get_statistics()` in
 `counters.py`:
 ...
 > {{{
 >                     id_str1 = '%s/%s/%s' % (cls, zone, attr)
 >                     id_str2 = '%s/%s/%s' % (cls, self._entire_server,
 attr)
 > }}}

 Thank you for consideration. I applied. Please see
 {{{
 8288bf4 [2884] do not reuse the string of format
 }}}

 > * In `xfrout_test.py.in`, it may be worth adding a `TEST_RRCLASS_STR` at
 >   the top to avoid the many `to_text()` calls.

 I replaced it.  Please see
 {{{
 fcea4de [2884] s/TEST_RRCLASS.to_text()/TEST_RRCLASS_STR/g
 }}}

 > * I suggest some more code comment at the top of `_add_counter()` (maybe
 >   with an example identifier) so it is easily readable,
 ...
 >   I follow what the code is doing now, but it took me 5 minutes for
 >   running the code in my head. :)
 Sorry for inconvenience. :( I added a note including an example.  Please
 see
 {{{
 ca3f4ec [2884] add a note for _add_counter()
 }}}

 Regards,

-- 
Ticket URL: <http://bind10.isc.org/ticket/2884#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development