BIND 10 #2931: Receiving notifications, python part
BIND 10 Development
do-not-reply at isc.org
Wed Jul 3 21:22:20 UTC 2013
#2931: Receiving notifications, python part
-------------------------------------+-------------------------------------
Reporter: vorner | Owner:
Type: task | vorner
Priority: high | Status:
Component: Inter-module | reviewing
communication | Milestone:
Keywords: | Sprint-20130709
Sensitive: 0 | Resolution:
Sub-Project: Core | CVSS Scoring:
Estimated Difficulty: 5 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| shared memory data source
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by pselkirk):
* owner: pselkirk => vorner
Comment:
In the department of philosophy, one could argue (as you have) that
unsubscribing twice with the same ID is an error, and deserves to have an
exception raised. On the other hand, one could argue that the end result
is what matters - the callback is definitely unsubscribed. At least the
action is clearly defined and tested.
The other thing that caught my eye is that callbacks are called in ID
order, and you actually sort them to enforce that. Is there any real
benefit to sorting? I'm not objecting, just curious.
The code is okay to merge with or without change.
--
Ticket URL: <http://bind10.isc.org/ticket/2931#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list