BIND 10 #2967: zonemgr should use general datasource configuration, not Auth/database_file

[BIND 10 Development]

#2967: zonemgr should use general datasource configuration, not Auth/database_file
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  vorner
            Priority:  medium        |                       Status:
           Component:  xfrin         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130709
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by pselkirk):

 * owner:  pselkirk => vorner


Comment:

 Replying to [comment:17 vorner]:
 > What happened to the branch? Was it rebased? Why? Why didn't the ticket
 say so?

 I rebased it because you asked me to in comment:15. Perhaps it would have
 been better to rebase while merging to master (or to cherry-pick the
 ticket commits), but that's not what you asked for.

 > But my idea was more like having it as variable inside the mock finder
 object. A new one would be created each time, so overwriting it would not
 influence other tests. Then it would not look like a global constant.
 Anyway, this is good.

 Sure, fine. This is no prettier or uglier than the last version, but it
 eliminates 3 identical embedded methods, so that's for the good.
 {{{#!python
     self.zone_refresh._datasrc_clients_mgr.datasrc_client.rdata_net =
 soa_rdata
 }}}

 > I don't have a good feeling even when we repeat one-line functions in
 multiple places. So I would prefer the one-line function to move there.
 Or, not define the function and just provide the result there. I think
 there was just one place that used it.

 There are 2 calls to this function, else I would have inlined it.
 Actually, I found one of them to be in error (`format_zone_str` was not
 appropriate there), so I inlined both.

 > The code would look good, but I can't compile it. It seems to be related
 to the errors in master.

 That's odd. It builds fine for me both in my dev repo, and in fresh clone.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2967#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development