BIND 10 #3048: Remove log messages from ServerHooks methods used during hook registration

BIND 10 Development do-not-reply at isc.org
Wed Jul 10 16:00:13 UTC 2013


#3048: Remove log messages from ServerHooks methods used during hook registration
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130717
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => stephen


Comment:

 '''server_hooks.cc'''
  Comment before ServerHooks constructor: "One method to initialize hook
 names is to use static initialization.". It should say "The only
 recommended method..." or "The only allowed method...".

 Comment for initialized(): " This used during construction." => "This is
 used during construction."

 There is no changelog entry, but I think the scope of changes is small
 enough to not need one.

 After you address those two comments above, the code will be ready to
 merge, but please do not merge it until #2995 is merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3048#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list